Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds missing argument in MetaController which caused page crash #12240

Merged
merged 1 commit into from Jan 22, 2019
Merged

Adds missing argument in MetaController which caused page crash #12240

merged 1 commit into from Jan 22, 2019

Conversation

tomas862
Copy link
Contributor

@tomas862 tomas862 commented Jan 21, 2019 •
edited by eternoendless

Questions Answers
Branch? develop
Description? Seems like after the rebase which happened on the weekend page crashed due to small issue.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? #12239
How to test? go to page and it will load now without an error

This change is Reviewable

@prestonBot prestonBot added develop Branch Bug Type: Bug labels Jan 21, 2019
@matks matks added the Waiting for QA Status: action required, waiting for test feedback label Jan 21, 2019
@matks matks added this to In progress in PrestaShop 1.7.6 via automation Jan 21, 2019
@matks matks removed this from In progress in PrestaShop 1.7.6 Jan 21, 2019
@matks matks added this to the 1.7.6.0 milestone Jan 21, 2019
@mbadrani mbadrani added QA ✔️ Status: check done, code approved and removed Waiting for QA Status: action required, waiting for test feedback labels Jan 22, 2019
@PierreRambaud PierreRambaud merged commit 63f9cb3 into PrestaShop:develop Jan 22, 2019
@PierreRambaud
Copy link
Contributor

Thanks @tomas862

@tomas862 tomas862 deleted the bug-fixes-from-develop/cms-page-not-working branch January 22, 2019 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matks matks matks approved these changes

Assignees
No one assigned
Labels
Bug Type: Bug develop Branch QA ✔️ Status: check done, code approved
Projects
None yet
Milestone
1.7.6.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tomas862 @PierreRambaud @matks @prestonBot @mbadrani